hyperledger-firefly / hyperledger-firefly/evmconnect

Improved error messages for `estimateGas` failures

Open
#76 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
17
Forks
20
Avg merge
2d 6h
Merged PRs (30d)
18

Description

Currently, some estimateGas failures result in an `""` being passed to firefly. This seems to be because `""` is the default catch in `mapError`.

The log message that is printed `Gas estimation failed for a non-revert reason:` is much more helpful than the empty string passed back to FireFly.

Example error log:
```
{"@timestamp":"2023-04-25T11:35:59.627Z","level":"error","message":"Gas estimation failed for a non-revert reason: (call result: \u003cnil\u003e)","prefix":"evmconnect"}
```

Error reported by FireFly in failed operation:
```
FF10111: Error from ethereum connector: {"error":""}
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.