hyperledger-firefly / hyperledger-firefly/evmconnect

Blockchain operations moving from `Failed` to `Pending`

Open
#69 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
17
Forks
20
Avg merge
2d 6h
Merged PRs (30d)
18

Description

FireFly integration tests are seeing blockchain operations move from `Failed` to `Pending` status after evm revert errors:

```
[33;1mfirefly_core_0_1 |[0m [2023-04-05T00:29:46.239Z] DEBUG ethereum updating operation default:f79a082e-3283-4659-a378-5d3e737f9381 status=Failed error=FF10111: Error from ethereum connector: FF23021: EVM reverted: CustomPin: FireFly address has not been set ns=default pid=1
[33;1mfirefly_core_0_1 |[0m [2023-04-05T00:29:46.508Z] DEBUG ethereum updating operation default:f79a082e-3283-4659-a378-5d3e737f9381 status=Failed error=FF10111: Error from ethereum connector: FF23021: EVM reverted: CustomPin: FireFly address has not been set ns=default pid=1
[33;1mfirefly_core_0_1 |[0m [2023-04-05T00:29:47.021Z] DEBUG ethereum updating operation default:f79a082e-3283-4659-a378-5d3e737f9381 status=Failed error=FF10111: Error from ethereum connector: FF23021: EVM reverted: CustomPin: FireFly address has not been set ns=default pid=1
[33;1mfirefly_core_0_1 |[0m [2023-04-05T00:29:48.033Z] DEBUG ethereum updating operation default:f79a082e-3283-4659-a378-5d3e737f9381 status=Failed error=FF10111: Error from ethereum connector: FF23021: EVM reverted: CustomPin: FireFly address has not been set ns=default pid=1
[33;1mfirefly_core_0_1 |[0m [2023-04-05T00:29:50.049Z] DEBUG ethereum updating operation default:f79a082e-3283-4659-a378-5d3e737f9381 status=Pending ns=default pid=1
[33;1mfirefly_core_0_1 |[0m [2023-04-05T00:29:55.662Z] DEBUG ethereum updating operation default:f79a082e-3283-4659-a378-5d3e737f9381 status=Succeeded ns=default pid=1
```

It seems wrong for an operation that has reached a "final" state of either `Failed` or `Succeeded` to ever move out of that state.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.