hyperledger-firefly / hyperledger-firefly/cli

Use of deprecated config keys `org.identity` and `dataexchange.https`

Open
#145 0 comments 0 reactions 1 assignee Claimed by @nguyer View on GitHub
Dominant language
Go
Stars
66
Forks
64
PR merge metrics
No merged PRs in 30d

Description

A few releases back (can't remember exactly when) this config was deprecated:
https://github.com/hyperledger/firefly-cli/blob/03797a8484fb7df6d277d236d99a6fc79bdaa2bb/internal/core/firefly_config.go#L71

It's now `org.key`.
Would be good for the CLI to switch over, as it will print a warning on every start up that the old config is used.

Note that the same is now true in v0.13.0 for `dataexchange.https` here (now `dataexchange.ffdx`):
https://github.com/hyperledger/firefly-cli/blob/03797a8484fb7df6d277d236d99a6fc79bdaa2bb/internal/core/firefly_config.go#L105

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.