hyperium / hyperium/hyper

Add the ability to safely read into ReadBuf

Open
#3,509 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

C-feature
Dominant language
Rust
Stars
16.3k
Forks
1.8k
Avg merge
1d 22h
Merged PRs (30d)
14

Description

Is your feature request related to a problem? Please describe.
It is impossible to write an implementation of hyper::rt::Read because ReadBufCursor cannot be written to safely.

Describe the solution you'd like
Have a method that initializes the read buffer by zeroing it and then returning an &mut [u8] that can be filled safely. E.g. this.

Describe alternatives you've considered
N/A

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating ReadBufCursor and the hyper::rt::Read implementation in the repository, then compare their behavior with Tokio's ReadBuf::initialize_unfilled documentation. The change is complete when the read buffer is safely initialized and the method returns a mutable byte slice that implementations can fill, with relevant tests covering the behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
api, backend-api-design
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.