poll_write_buf landed but comment and other issue says "being waited on"
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 16.3k
- Forks
- 1.8k
- Avg merge
- 1d 22h
- Merged PRs (30d)
- 14
Description
Version
In latest master, 1.0 rc1+
Platform
Just in the source. Not a runtime problem.
Description
Was reading through hyper code, finding everything well organized and very few TODOs. Found a TODO from years ago and now its reason seems outdated. As 1.0 is about to be released, thought someone might want to revisit. Maybe it's as simple as the comment being changed. Sorry I'm in no position to suggest a PR as I don't know enough about the implications of the change one way or the other.
https://github.com/hyperium/hyper/blob/96dcc79b62572c591b8062f26db602868de5b5f0/src/proto/h1/io.rs#L304-L307
This closed item https://github.com/hyperium/hyper/pull/2317 also said there should be a change back once the feature had landed in tokio. It seems to have landed in tokio 0.5.1 and appears to me to still be there.
(How do I remove the bug label?)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at src/proto/h1/io.rs lines 304-307 and compare the TODO with Tokio 0.5.1 and closed PR #2317. Confirm whether poll_write_buf landed and whether the comment is outdated; done means the requested source comment is accurately resolved after checking the relevant implications.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100