hyperium / hyperium/hyper

`Graceful` struct is not accessible

Open
#2,582 4 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
16.3k
Forks
1.8k
Avg merge
1d 22h
Merged PRs (30d)
14

Description

Hello, I believe I have found a bug/inconsistency between the Server::with_graceful_shutdown function and the Graceful struct : the former is exposed as part of the public API, and returns a Graceful object, although the latter is not publicly accessible (as it is part of the shutdown private module).

This causes problems when trying to use the graceful shutdown capabilities and passing a Graceful object across functions, as an argument or return value of type Graceful in a custom function cannot be properly typed.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the public Server::with_graceful_shutdown API and the private shutdown module that defines Graceful. Check how the returned type can be named across function boundaries, then verify that the public API exposes a usable Graceful type without breaking existing graceful-shutdown behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
api
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.