hyperium / hyperium/hyper

The `size_hint` in `HttpBody` can change behavior when making GET requests with bodies

Open
#2,444 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-body
Dominant language
Rust
Stars
16.3k
Forks
1.8k
Avg merge
1d 22h
Merged PRs (30d)
14

Description

This is a subtle one! Bodies for GET requests are ignored, unless the HttpBody::size_hint provides an exact size, in which case they are transmitted. The size_hint should not affect behavior in this way, AIUI.

I was using the general Client::request API to pass through a request that happened to be a GET with a body.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the general Client::request API and the HttpBody::size_hint handling described in the report. Reproduce a GET request with a body using exact and non-exact size hints, then verify that the body behavior is consistent regardless of the hint.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.