hyperium / hyperium/http

Make it easier to mutate query parameters in `Uri`

Open
#577 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

A-uri B-rfc S-feature
Dominant language
Rust
Stars
1.4k
Forks
378
Avg merge
1d 21h
Merged PRs (30d)
5

Description

In the AWS SDK, we needed to insert query parameters in an existing Uri for our presigning implementation. There wasn't an easy way to do this in http, so we ended up writing the following QueryWriter:

https://github.com/awslabs/smithy-rs/blob/a0539e20b069a7de021c84521d8f3c7ba098ad6d/aws/rust-runtime/aws-sigv4/src/http_request/query_writer.rs#L9-L73

It would be nice to have built-in utilities for manipulating URI components either in this crate, or in a separate related utility crate.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the linked AWS SDK QueryWriter implementation in aws/rust-runtime/aws-sigv4/src/http_request/query_writer.rs, especially lines 9-73, and compare its needs with the URI types provided by this crate. The issue is complete when the crate or a related utility crate offers a settled, documented way to insert or otherwise manipulate query parameters in an existing Uri.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
api
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.