hyperium / hyperium/http

Any reason HeaderMap is generic

Open
#567 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
1.4k
Forks
378
Avg merge
1d 21h
Merged PRs (30d)
5

Description

I don't think this is a real issue, but is there any reason why HeaderMap is generic over the value? Since it is using only the HeaderValue not sure what this adds. By removing that generic param, the code will be simplified and potentially reduce compilation times.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at src/header/map.rs lines 45-52 and trace how HeaderMap uses its generic value parameter versus HeaderValue. Inspect the surrounding type and its usages, then run the existing test suite and compilation checks; done means establishing whether removing the parameter is safe and confirming the resulting code still builds and tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
networking
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.