hyperium / hyperium/http-body

adding benchmarks

Open
#108 0 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
173
Forks
69
Avg merge
6d 15h
Merged PRs (30d)
4

Description

I'm looking into adding benchmarks to this library, inspired by https://github.com/hyperium/hyper/blob/master/benches/body.rs
The goal is to make it easier to check whether a change has a positive impact or not.

Before starting the implementation, I'd like to gather some initial feedback from the maintainers:

  • do you think it's a good idea?
  • if yes, do you have a preference which library should be used? (criterion, divan, other?)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the linked hyper benchmark at benches/body.rs and the issue's references to criterion and divan. Compare the proposed benchmark approach with this library's current structure and gather maintainer feedback on whether benchmarks are wanted and which library to use. Done is not defined until that direction is decided.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
performance
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.