write method calls send_data before poll_ready
Open
Nobody has claimed this yet.
C-bug
E-easy
- Dominant language
- Rust
- Stars
- 890
- Forks
- 136
- Avg merge
- 14d 20h
- Merged PRs (30d)
- 2
Description
On stream.rs#L28-L29, stream.send_data is called prior to stream.poll_ready.
stream.poll_ready should be called first, similar to as described in https://docs.rs/futures/latest/futures/sink/trait.Sink.html#tymethod.poll_ready.
Thanks for considering this issue, and let me know if you have any questions!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect stream.rs around lines 28-29 and compare the call order with the futures Sink::poll_ready documentation linked in the issue. The work is done when poll_ready is called before send_data, with the resulting behavior verified against the relevant stream handling.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100