hyperium / hyperium/h2

Default server configuration prevents the use of server pushes

Open
#755 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
1.6k
Forks
382
Avg merge
20h 23m
Merged PRs (30d)
9

Description

https://github.com/hyperium/h2/blob/a8af2358647cd2a68f851dfe3228cc3116654223/src/server.rs#L1378-L1379

This is arguably a bad default, given that it will block any server pushes unless the client explicitly sends a non-zero MAX_CONCURRENT_STREAMS setting.

I don't think we should limit the server that way unless the client explicitly requests that.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read src/server.rs around lines 1378-1379 and trace how MAX_CONCURRENT_STREAMS is applied to the server configuration. Run the relevant HTTP/2 server tests, then verify that server pushes are not blocked unless the client explicitly requests a non-zero limit.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.