hyperium / hyperium/h2

Mem leak when releasing stream

Open
#631 3 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
1.6k
Forks
382
Avg merge
20h 23m
Merged PRs (30d)
9

Description

https://github.com/hyperium/h2/blob/756384f4cdd62bce3af7aa53a156ba2cc557b5ec/src/proto/streams/counts.rs#L164-L168

There may still leave some bytes releated to the stream in https://github.com/hyperium/h2/blob/756384f4cdd62bce3af7aa53a156ba2cc557b5ec/src/proto/streams/recv.rs#L52 when Counts remove a closed Stream.
This may cause mem leak, Should we remove bytes releated to the stream in remove function?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the referenced Counts removal code in src/proto/streams/counts.rs around lines 164-168, then trace the related bytes in src/proto/streams/recv.rs around line 52. Determine whether removing a closed Stream leaves those bytes retained, and verify that the stream's associated memory is released when removal completes.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
networking
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.