hyperium / hyperium/h2

Bad feedback on reset stream

Open
#592 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
1.6k
Forks
382
Avg merge
20h 23m
Merged PRs (30d)
9

Description

When a stream is reset before calling send_response, the error returned is a Error::User.

That variant doesn't contain any data telling what caused the issue. I propose adding some form of feedback to at least the debug implementation.

This is the file where the error is returned, without any context.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading src/proto/streams/state.rs around lines 121-124, where the reset-before-send_response error is returned. Trace the reset path to identify what context is available, then define the change as making the debug output distinguish the cause instead of exposing only Error::User; verify the resulting error feedback with the relevant existing behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.