Improve Error when handshake determines peer isn't using HTTP2
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 1.6k
- Forks
- 382
- Avg merge
- 20h 23m
- Merged PRs (30d)
- 9
Description
If a client connects to a server that doesn't respond with HTTP2, it currently returns protocol error: frame with invalid size. While technically correct, this is as clear as mud. This should really be some sort of handshake error, perhaps with the frame with invalid size error as the source().
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files or tests. Start by tracing the handshake response handling and the source of the frame with invalid size error; done means a peer that does not use HTTP/2 produces a clearer handshake error while preserving the original error as its source.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100