hyperium / hyperium/h2

Move `enqueue_reset_expiration` into transition logic

Open
#211 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Rust
Stars
1.6k
Forks
382
Avg merge
20h 23m
Merged PRs (30d)
9

Description

Doing so will reduce the calls to this function to one location. To make this change, pending_reset_expired needs to be moved from recv into counts.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search for enqueue_reset_expiration and pending_reset_expired, then read the recv, counts, and transition logic around those symbols. Consolidate the function's calls in the transition logic, move pending_reset_expired from recv into counts, and run the existing test suite to confirm behavior is unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
networking
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.