hyperium / hyperium/h2

Correctly handle changes in received MAX_FRAME_SIZE settings.

Open
#197 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
1.6k
Forks
382
Avg merge
20h 23m
Merged PRs (30d)
9

Description

This is a placeholder issue.

I believe that there might be a problem if a larger MAX_FRAME_SIZE setting is received while self.next in framed_write is set to a continuation frame. Specifically, self.next is originally set under the assumption that no further data can be written until the existing frame is flushed.

I'm not 100% sure there is a problem, but it looks a bit suspect.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by examining the framed_write path, especially how self.next is set for continuation frames and how received MAX_FRAME_SIZE changes are handled. Confirm whether a larger setting can invalidate the existing assumption about flushing, then reproduce the behavior and add coverage if a problem is found.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
networking
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.