hyperfiddle / hyperfiddle/rcf

Tests that fail because they throw error don't report with a ❌

Open
#72 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Clojure
Stars
301
Forks
14
PR merge metrics
No merged PRs in 30d

Description

When a test fails because it throws, it seems that it's reported differently:

(rcf/tests
 (throw (ex-info "" {}))
 := 10)

Will report:

ERROR in () (:)
expected: (hyperfiddle.rcf/= (throw (ex-info "" {})) 10)
  actual: clojure.lang.ExceptionInfo: 
{}
 at ...

Where-as:

(rcf/tests
 20
 := 10)

Will report:

❌ FAIL in () (...:460)
expected: (= 20 10)
  actual: (not (= 20 10))

I don't mind that it says ERROR instead of FAIL, but it be nice to still have a big red ❌

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the two rcf/tests examples in the issue and compare their reported output. Trace the reporting path for the thrown ex-info case; done means that error reports still show ERROR if desired but include the large red ❌ indicator like ordinary failures.

Written by the indexing model from the issue text.

Assessment

Tech stack
clojure
Domain
testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.