hyochan / hyochan/react-native-masonry-list

Inclusion of `expo` as a peer dependency is causing warnings

Open
#60 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
437
Forks
58
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**
"expo" is listed as a dependency in the core project but only used in the Example project. Is there a reason for this? It is causing warnings to be thrown in non-expo projects due to a missing peer dependency. Maybe it needs to move to `devDependencies`?

**To Reproduce**
In a non-expo project, add `"@react-native-seoul/masonry-list": "1.4.2",` to `package.json` and run `yarn install`, see warning:
```
YN0002: │ @test/mobile@workspace:packages/mobile doesn't provide expo (pb91be), requested by @react-native-seoul/masonry-list
```

**Expected behavior**
No warnings should print to console unless expo is being used in the core project itself. Maybe we need

**Screenshots**
N/A

**Desktop (please complete the following information):**

N/A

**Smartphone (please complete the following information):**

N/A

**Additional context**
using Yarn 3 and it shows warnings to help manage peer deps

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.