hydrusnetwork / hydrusnetwork/hydrus
Capture ffmpeg standard error output
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 3.2k
- Forks
- 207
- PR merge metrics
- No merged PRs in 30d
Description
Currently, Hydrus doesn't display any information about the kind of error when ffmpeg encounters an issue and doesn't return any metadata:
STDERR Response: b''
2020/07/09 16:58:46: Error when processing [redacted] !
2020/07/09 16:58:46: Traceback (most recent call last):
File "hydrus/hydrus/client/importing/ClientImportFileSeeds.py", line 1318, in WorkOnURL
File "hydrus/hydrus/client/importing/ClientImportFileSeeds.py", line 569, in DownloadAndImportRawFile
File "hydrus/hydrus/client/importing/ClientImportFileSeeds.py", line 816, in Import
File "hydrus/hydrus/client/importing/ClientImportFileSeeds.py", line 89, in DoWork
File "hydrus/hydrus/client/importing/ClientImportFileSeeds.py", line 174, in GenerateInfo
File "hydrus/hydrus/core/HydrusFileHandling.py", line 207, in GetFileInfo
File "hydrus/hydrus/core/HydrusAudioHandling.py", line 46, in VideoHasAudio
File "hydrus/hydrus/core/HydrusVideoHandling.py", line 206, in GetFFMPEGInfoLines
hydrus.core.HydrusExceptions.DataMissing: Cannot interact with video because FFMPEG did not return any content.
For debugging purposes, it would be useful if Hydrus could capture ffmpeg's standard error output and log that, especially given that ffmpeg apparently doesn't log errors to a file by default.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in hydrus/core/HydrusVideoHandling.py at GetFFMPEGInfoLines, then trace the call from HydrusAudioHandling.py shown in the traceback. Capture ffmpeg's standard error and log it when no metadata is returned, so the failure includes useful diagnostic output.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100