hunterloftis / hunterloftis/stoppable

Memory leak

Open
#30 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
404
Forks
25
PR merge metrics
No merged PRs in 30d

Description

I was banging my head trying to figure out why my Node 12.8.3 process' memory footprint was increasing indefinitely and managed to narrow down the problem to this module (used by @godaddy/Terminus in my case).

For some reason, the server._pendingSockets map would not be properly maintained, keeping references to thousands of requests.

As soon as I switched from using stoppable to http-terminator, the problem went away.

Please note that I am using node-spdy for the http2 server, since the core implementation is not yet supported by express.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.