hunterloftis / hunterloftis/stoppable
Should we also send "Connection: Close" ?
Open
- Dominant language
- JavaScript
- Stars
- 404
- Forks
- 25
- PR merge metrics
- No merged PRs in 30d
Description
Hi, This module seems to do everything the correct way but I wonder would it be more correct to also send the "Connection: Close" header to the client on the last inflight request before closing the socket? Otherwise we will end "Connection: Keep-Alive" back and the client will not be expecting the socket to close.
i.e. the logic would go here: https://github.com/hunterloftis/stoppable/blob/master/lib/stoppable.js#L27
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.