hunterloftis / hunterloftis/pbr

fixtures.zip fails to make properly

Open
#37 10 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Go
Stars
1.2k
Forks
40
PR merge metrics
No merged PRs in 30d

Description

```
unzip fixtures.zip
Archive: fixtures.zip
warning [fixtures.zip]: 409970 extra bytes at beginning or within zipfile
(attempting to process anyway)
[...]
inflating: __MACOSX/fixtures/models/._cornellbox
Makefile:16: recipe for target 'fixtures' failed
make: *** [fixtures] Error 1
```

Assuming the "extra bytes" warning causes zip to exit non-zero, which ends up leaving the __MACOSX and fixtures.zip garbage in the working directory.

on an ubuntu 16.04 machine.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at the fixtures target in Makefile:16 and reproduce the failure with the reported fixtures.zip archive on Ubuntu. Check how the unzip warning affects the target and its generated files; done means the fixtures target completes without leaving __MACOSX or invalid archive artifacts in the working directory.

Written by the indexing model from the issue text.

Assessment

Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.