hunterloftis / hunterloftis/jackrabbit

Calls to publish messages before "connected" event should raise error

Open
#49 3 comments 1 reaction 0 assignees View on GitHub
Dominant language
JavaScript
Stars
291
Forks
65
PR merge metrics
No merged PRs in 30d

Description

Hoping I can get around to a PR for this, but in the mean time just marking this down.

Trying to publish when there is not an active connection should raise an error. Instead, the event is swallowed and the sender is none the wiser.

I would think you'd want to make this explicitly clear to the caller right away via raising the error.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.