humanmade / humanmade/wp-simple-saml

Allowed hosts array will contain one empty string item if no option set

Open
#97 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
125
Forks
37
PR merge metrics
No merged PRs in 30d

Description

```php
array_map( 'trim', explode( ',', Admin\get_sso_settings( 'sso_whitelisted_hosts' ) ) );
```

Will resolve to `[ '' ]` if no hosts have been added to the list. We maybe also should have at least the main or current site URL as an allowed host. This is based on the derived redirect value, so really we just want to prevent redirecting outside of the WP site.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.