humanmade / humanmade/wp-simple-saml
Role mapping filter is always reset when using in network activated mode
Open
bug
- Dominant language
- PHP
- Stars
- 125
- Forks
- 37
- PR merge metrics
- No merged PRs in 30d
Description
Because we don't return the roles early if not empty when filtered in `get_user_roles_from_sso()` they will always get clobbered by the `if` statement which sets a fresh empty array.
The function returns the `$network_roles` array if it is not `null`, but an empty array is not `null`.
https://github.com/humanmade/wp-simple-saml/blob/master/inc/namespace.php#L823
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.