humanmade / humanmade/tachyon

Smart Cropping Unexpectedly Applies Rule of Thirds with no off mechanism

Open
#543 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
295
Forks
4
Avg merge
15d 7h
Merged PRs (30d)
1

Description

I'm dealing with an issue where a client has recently moved to Tachyon, but now headshots that were centred are postioned off to the side.

Further investigation reveals that smart media cropping tool is applying the smart crop strategy, and the smart cropping library is applying the rule of thirds, shifting the faces to the left or right and causing issues for stakeholders.

https://github.com/humanmade/tachyon/blob/24cbb1229a24d9ec5ffdc9492a85d683dacf10d6/src/lib.ts#L255

I can find no mechanism to turn the rule of thirds off and have resorted to disabling smart cropping as a feature in the clients codebase to mitigate the issue.

I can reliably recreate the problem and toggle it using https://29a.ch/sandbox/2014/smartcrop/examples/testbed.html by checking and unchecking the rule of thirds box.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.