humanmade / humanmade/tachyon

Support rotation

Open
#123 1 comment 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
TypeScript
Stars
295
Forks
4
Avg merge
15d 7h
Merged PRs (30d)
1

Description

In WP 5.5 the image block introduced inline image editing. We could potentially hijack the API endpoint that generates a modified image if we also supported rotation. Rotation does add a bit of complexity when calculating & applying crop dimensions however. We'll need to apply this consistently eg.

- Rotate & then crop (crop dimensions are for rotated image)
- Crop & then rotate (crop dimensions are pre-rotation)

The WP editor assumes rotating and then cropping, and that fits the model of values an image editor UI is likely to be able to produce so I feel it's the best approach.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.