humanmade / humanmade/tachyon-plugin

Include previously registered sizes in `filter_image_downsize()`

Open
#52 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
86
Forks
16
PR merge metrics
No merged PRs in 30d

Description

The downsizing filter uses `Tachyon::image_sizes()` to determine valid sizes for an image to account for image sizes registered after an image was uploaded.

If registered sizes were removed after an image was uploaded, the legacy size will be referenced in `wp_get_attachment_metadata( $attachment_id )['sizes']`. To account for these, the downsize and content filters should combine both the meta sizes with registered sizes.

Design decision: should a clash exist between the legacy and current image size names, which version should be deferred to?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.