humanmade / humanmade/linter-bot
Add linter to detect changes with ignores
- Dominant language
- JavaScript
- Stars
- 16
- Forks
- 2
- Avg merge
- 17d 47m
- Merged PRs (30d)
- 1
Description
To implement ACR for Altis, we need to check for any changes which introduce or change `// phpcs:ignore` lines. We also want to fail if `phpcs:disable` is detected.
This can be implemented as a new linter which is disabled by default. We could potentially use Danger.js for this to avoid implementing a whole checking engine.
Notably, this may need to operate on diffs, whereas our existing linters check against the whole codebase. This may require changes to the system.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by reviewing the existing linter system and how its checks run against the whole codebase. Determine whether a disabled-by-default linter can use Danger.js to inspect diffs for added or changed `// phpcs:ignore` lines and any `phpcs:disable`; done means the check reliably fails for those changes without affecting default runs.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, php
- Domain
- ci-cd, tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100