humanmade / humanmade/coding-standards

WPCS/I18n refactor breaks HM-Minimum on PHP 8.2

Open
#308 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
160
Forks
17
PR merge metrics
No merged PRs in 30d

Description

WPCS recently deprecated a temporary property called `check_translator_comments` that is currently being used in the HM-Minimum ruleset.

Commit details here: https://github.com/WordPress/WordPress-Coding-Standards/commit/31064cf7a49931c0cf165b923ac0a86c20b2e4b4

Affected code is here: https://github.com/humanmade/coding-standards/blob/e8ec095e7128a3819e254a238902746ec00ece0d/HM-Minimum/ruleset.xml#L160-L163

I think the solution is as easy as:

```xml


...
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.