humanmade / humanmade/bulk-lighthouse
searchParams are not unique per environment
- Dominant language
- JavaScript
- Stars
- 13
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Description
The typical usecase is for searchParams to allow testing of an environment's pages without having to login, through the use of a secret query parameter. However as the searchParams are not environment specific that means that this url bypasses the cache on other environments as well.
As we cannot ignore logged in status for caching purposes we cannot adapt the cache configuration to ignore the searchParams. Therefore we should add support to make it environment specific.
currently:
```
"searchParams": {
"project-auth": "my-generated-secret-hash"
},
```
expected:
```
"searchParams": {
"staging": {
"project-auth": "my-generated-secret-hash"
}
},
```
Note: generic searchParams might be a valid usecase as well, so this should be in addition to the current logic.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.