humanmade / humanmade/asset-loader

Version inference logic doesn't work in some builds

Open
#54 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
26
Forks
2
PR merge metrics
No merged PRs in 30d

Description

Reading the `md5` of the asset manifest is an invalid way to infer the version of a build, since with a file like,
```json
{
"editor": "editor.js"
}
```
the contents of the file will never change and all builds will use the same version number. This can cause stale assets due to various layers of caching.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.