humanmade / humanmade/altis-dev-tools

Incorrect version of Requests dependency loaded

Open
#404 2 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
PHP
Stars
7
Forks
0
Avg merge
1d 9h
Merged PRs (30d)
2

Description

I've been working through various PHP 8.1 related issues, and one thing I noticed is that due to a dependency is this module, WordPress core loads an incorrect version of the Requests library:

```
[327] => /usr/src/app/wordpress/wp-includes/class-wp-http.php
[328] => /usr/src/app/vendor/rmccue/requests/library/Requests.php
```

This is because `class-wp-http.php` calls `class_exists` on `Requests`, causing the autoloader to kick in and load the one from vendor, instead of the version shipped with WordPress core. The dependency comes from:

* altis/dev-tools -> lucatume/wp-browser
* lucatume/wp-browser -> wp-cli/wp-cli
* wp-cli/wp-cli -> rmccue/requests

Acceptance criteria:

- [ ] WordPress should load the Requests library bundled with Core

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.