humanmade / humanmade/altis-cms

Local storage quota exceeded can crash editor

Open
#242 1 comment 0 reactions 0 assignees View on GitHub
bug could have
Dominant language
PHP
Stars
46
Forks
4
Avg merge
14h 31m
Merged PRs (30d)
13

Description

When opening Gutenberg in private browsing in Firefox, the local storage quota is much lower than usual. This can lead to the quota easily being exceeded.

In our [editor settings override code](https://github.com/humanmade/altis-cms/blob/master/assets/editor-settings.js), we override Gutenberg's settings. It's easily possible for this to hit and exceed the quota thanks to Pinpoint's use of local storage as well, and this throws a quota exception. The exception acts as an uncaught exception which then crashes Gutenberg into an unrecoverable state.

We need to catch these exceptions inside `updateSettings`.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.