humanmade / humanmade/altis-cloud

Set the S3 Endpoint correctly

Open
#877 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
PHP
Stars
9
Forks
2
Avg merge
6d 1h
Merged PRs (30d)
23

Description

Altis infra uses the global s3 endpoint of s3.amazonaws.com for _all_ region's s3 buckets. Things like S3_Uploads::get_s3_location_for_url() also assumes a global hardcoded hostname. However, if you try to generate URLs with the SDK, it will generate `$bucket.s3.$region.amazonaws.com` (with the exception of us-east-1, which defaults to the global hostname) style URLs. That's an issue for things like S3 Uploads Private Media as the signature will then not match.

We should make sure that the SDK's S3Client is set to use the global hostname to ensure compatibility with the rest of the Altis infra.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.