humanmade / humanmade/altis-browser-security

Compatibility: integrity hashes not generated using Bedrock

Open
#24 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
10
Forks
3
PR merge metrics
No merged PRs in 30d

Description

Hi,

Currently Altis Browser Security doesn't generate integrity hashes for assets when using a [Bedrock](https://github.com/roots/bedrock) setup. It's checking `domain.com/wp` but most of them are in `domain.com/app/[..]` This is due the use of [`site_url()`](https://github.com/humanmade/altis-browser-security/blob/c169c7e77d300186e2351589fcd8ccd870a91b05/inc/namespace.php#L169-L177) instead of `home_url()`. Is this something you can change?

Further I noticed that WP Core assets don't get integrity hashes (non Bedrock too, I checked the source of humanmade.com to be sure). I think because the [paths are relative](https://github.com/WordPress/wordpress-develop/blob/65561851298cf189c139aed05a7fef7a869356e6/src/wp-includes/script-loader.php#L129). Is this intended?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.