humanmade / humanmade/altis-browser-security

Apply needs_quotes list after filtering

Open
#10 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
PHP
Stars
10
Forks
3
PR merge metrics
No merged PRs in 30d

Description

It is counterintuitive that the configuration value can
- omit quotes
- be a raw string

but that the values returned from `altis.security.browser.filter_policy_value` _must_ have quotes and _cannot_ be a raw string. I propose moving the logic within filter_policy_value around, to execute the array casting and quoting logic as the last step of the function, post-filtering, so that all filters can return directive values in the same (flexible) formats.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.