humanmade / humanmade/Workflows

Cannot deselect 'Send group email'

Open
#183 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
PHP
Stars
106
Forks
7
PR merge metrics
No merged PRs in 30d

Description

If you check the 'Send Group Email' box in a workflow:

CleanShot 2022-07-20 at 10 57 47@2x

If you uncheck the box, and save, emails will still be sent via group email.

It appears that this is caused because this line checks if the value is set, but does not check the value itself, so in theory an empty value would return true.

https://github.com/humanmade/Workflows/blob/cac43d591353447e06a89222c8b6f013a186734b/lib/destinations/email.php#L71

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.