humanmade / humanmade/S3-Uploads

Expand `wp s3-uploads verify` command to check all required permissions

Open
#501 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
2.2k
Forks
404
PR merge metrics
No merged PRs in 30d

Description

Right now, the wp s3-uploads verify CLI command is able to verify write and delete, but does not seem to internally call any functions which would also check the ListObjects permissions.

For context, we had an instance where our IAM permissions were mis-configured so we couldn't list objects, but writes/deletes were totally fine. wp s3-uploads verify didn't catch the issue (although wp s3-uploads ls did return the errors, which is how we ended up catching it).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the implementation of the wp s3-uploads verify command and compare its existing write/delete checks with the behavior of wp s3-uploads ls. Trace how list-permission errors are surfaced, then verify that the command detects and reports insufficient ListObjects permissions alongside the existing checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws, php
Domain
cli, cloud
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.