huggingface / huggingface/speechbox

An idea for enhancing punctuation restoration for non-space separated languages

Open
#8 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
357
Forks
40
PR merge metrics
No merged PRs in 30d

Description

Hello! Thank you for creating such a nice project. I was pleasantly surprised to see that you also utilized Whisper for punctuation restoration, as I had the same idea and my implementation is available here: (https://github.com/jumon/whisper-punctuator). In fact, your implementation looks nicer than mine 😆

I have one small suggestion for improvement. I noticed that your code splits words by spaces and only inserts punctuation marks after words. This approach may not work well for languages such as Japanese and Chinese, which do not use spaces to indicate word boundaries. It may be beneficial to allow punctuation insertion at other locations or to make it an optional feature.

Thank you!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.