huggingface / huggingface/setfit
[Minor] tqdm disabling doesn't work
Open
- Dominant language
- Jupyter Notebook
- Stars
- 2.8k
- Forks
- 267
- Avg merge
- 36m
- Merged PRs (30d)
- 5
Description
Thanks for shipping v1.0 @tomaarsen.
I found a small issue, it seems like `setfit.logging.disable_progress_bar()` doesn't work. I believe it's because this import:
https://github.com/huggingface/setfit/blob/107ca56c8cf6f2d3e79e2519d7e5ec24a95ccc56/src/setfit/modeling.py#L28
Should instead be importing the `tqdm` from `setfit.logging` like:
```python3
from .logging import tqdm
```
so that it can use `EmptyTqdm` when progress bars are disabled.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.