huggingface / huggingface/open-muse

Attention mask?

Open
#88 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
Python
Stars
359
Forks
30
PR merge metrics
No merged PRs in 30d

Description

Like in Stable Diffusion, no attention mask appears to be used for input tokens: https://github.com/huggingface/open-muse/blob/2a0365707c0c3d91b0b91bc456161db693652ff1/muse/pipeline_muse.py#L93-L101

But [according to third party analysis](https://github.com/huggingface/diffusers/pull/2634) this appears to have been a mistake all along. Do we have insight on whether attention masks would help for better prompt-image alignment?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.