huggingface / huggingface/neuralcoref

Missing implementation of doc embeddings during inference

Open
#338 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
2.9k
Forks
467
PR merge metrics
No merged PRs in 30d

Description

Document embeddings are not calculated during inference in [neuralcoref.pyx](https://github.com/huggingface/neuralcoref/blob/60338df6f9b0a44a6728b442193b7c66653b0731/neuralcoref/neuralcoref.pyx), but they are left at zeros.

https://github.com/huggingface/neuralcoref/blob/60338df6f9b0a44a6728b442193b7c66653b0731/neuralcoref/neuralcoref.pyx#L717

This causes a mismatch between inference and training input features (doc embeddings during training are correctly calculated in [document.py](https://github.com/huggingface/neuralcoref/blob/60338df6f9b0a44a6728b442193b7c66653b0731/neuralcoref/train/document.py#L534)). Is it a bug or is it intentional? There is a call to a method `get_average_embedding` as a comment but it does not exist.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.