huggingface / huggingface/lighteval

[FT] Align parameter names in config files and config classes

Open
#439 1 comment 1 reaction 1 assignee Claimed by @albertvillanova View on GitHub
feature
Dominant language
Python
Stars
2.5k
Forks
555
Avg merge
1d 6h
Merged PRs (30d)
1

Description

## Issue encountered
Currently, the example config files have a parameter named `dtype`.

When parsing the config file into the config class, this parameter is renamed to `model_dtype`.

## Solution/Feature
Align the name to `model_dtype` in both config files and config classes.

### Context:
In the config files
- it already exists a `model` parameter called `model_name`
- there are also `instance` parameters called `instance_type` and `instance_size`

This was discussed in:
- https://github.com/huggingface/lighteval/pull/434?new_mergebox=true#issue-2732500452

## Possible alternatives
Leave it as it is.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.