huggingface / huggingface/fuego
Shouldn't `private` default to `True` instead?
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 87
- Forks
- 9
- Avg merge
- 6m
- Merged PRs (30d)
- 1
Description
So I was wondering whether the `private` param in `.run` should default to `True` instead, as otherwise the dataset/space will be published automatically as public even though that may now be the desired behavior.
https://github.com/huggingface/fuego/blob/9766af580cfe6324d7d2baedfcb71c3eeb5fdbcd/src/fuego/run_on_spaces.py#L310
Let me know what you think! Also, if applicable, I can submit a small PR to change that.
P.S. I'd also like to know whether there's a specific topic/area that you want the community to contribute to, because I'd like to 🤗
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at src/fuego/run_on_spaces.py around line 310 and inspect the private parameter on .run. Confirm how its current default affects whether datasets or Spaces are published publicly; done means the intended default behavior is established and reflected there.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- huggingface, python
- Domain
- cloud
- Issue type
- Feature
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100