huggingface / huggingface/doc-builder

Bug: 'requests' should be a core dependency (install_requires) instead of a testing dependency

Open
#770 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
144
Forks
59
Avg merge
2d 5h
Merged PRs (30d)
13

Description

`requests` is currently listed only as a testing dependency. However, it appears to be used in the core logic of `doc-builder`, which means it should be part of the base `install_requires`.

https://github.com/huggingface/doc-builder/blob/72f7b0726a3e48eb1e7dc63d142bc2f86a7ab099/setup.py#L6-L16

https://github.com/huggingface/doc-builder/blob/72f7b0726a3e48eb1e7dc63d142bc2f86a7ab099/setup.py#L29

https://github.com/huggingface/doc-builder/blob/72f7b0726a3e48eb1e7dc63d142bc2f86a7ab099/pyproject.toml#L22-L33

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.