huggingface / huggingface/diffusers

Formulation of reverse diffusion process in DDPM ( 1 - alpha_prod_t = beta_prod_t assumption)

Open
#9,474 5 comments 0 reactions 0 assignees View on GitHub
bug stale
Dominant language
Python
Stars
34.5k
Forks
7.3k
Avg merge
3d 3h
Merged PRs (30d)
91

Description

### Describe the bug

I looked into sampling code of DDPM, and I believe there's a mistake:
#### I believe the code makes assumption that 1 - alpha_prod_t = beta_prod_t, which simply isn't true.

Original sampling algorithm:
[original paper](https://arxiv.org/pdf/2006.11239)
![image](https://github.com/user-attachments/assets/ce07bbb7-5a9d-44e6-9f0e-18bf42963317)

x_0 prediction from sample and predicted noise :

Eqn 15 from paper, as referenced in code snippet as well:
![Screenshot 2024-09-19 at 6 26 48 PM](https://github.com/user-attachments/assets/3ce27e0b-515b-4cd3-b722-454594139f83)

code implementation in diffusers:
https://github.com/huggingface/diffusers/blob/1e8cf2763d37fa66cfba2fb87acfe3443068ce43/src/diffusers/schedulers/scheduling_ddpm.py#L446-L449

### Here, it clearly seems like the 1 - alpha_prod_t = beta_prod_t is being used.

investigated from post by @AlejandroBaron in https://github.com/huggingface/diffusers/discussions/9431_

### Reproduction

I haven't tested out code, but this seems fundamental formulation issue.

### Logs

_No response_

### System Info

0.30.3

### Who can help?

@sayakpaul @DN6 @yiy

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.