huggingface / huggingface/diffusers

Clarification Needed on Hardcoded Value in Conditional Statement in LeditPP

Open
#8,760 3 comments 1 reaction 0 assignees View on GitHub
stale
Dominant language
Python
Stars
34.5k
Forks
7.3k
Avg merge
3d 3h
Merged PRs (30d)
91

Description

Hello @manuelbrack,

I was reviewing the source code and came across a line that seems to have a hardcoded value in a conditional statement. The line in question is:

https://github.com/huggingface/diffusers/blob/0bae6e447cba0459456c4f7e7e87d7db141d3235/src/diffusers/pipelines/ledits_pp/pipeline_leditspp_stable_diffusion.py#L1053

I understand that this condition decides whether cross_attention_mask, intersect_mask, or noise_mask is going to be used in the diffusion step, but any clarification on this this condition about the following questions will be appreciated:

- What is the significance of the value 800?
- Is this value based on empirical data, theoretical calculations, or an arbitrary choice?
- Are there specific scenarios or conditions under which this threshold was determined?
- Would it be possible to include a comment or documentation explaining this choice for future reference?

Thank you for your help!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.