huggingface / huggingface/diffusers
Wrong scale of dynamic thresholding in Jax implementation
Open
jax/flax
stale
- Dominant language
- Python
- Stars
- 34.5k
- Forks
- 7.3k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 91
Description
https://github.com/huggingface/diffusers/blob/f4fc75035f2d567dfe00fc6b8671ecd38dd144b2/src/diffusers/schedulers/scheduling_dpmsolver_multistep_flax.py#L164
Apparently, `q` in [jnp.percentile](https://jax.readthedocs.io/en/latest/_autosummary/jax.numpy.percentile.html) should between [0, 100] instead of [0, 1] as in torch.
Contributor guide
Assessment
This issue has not been assessed yet.